Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Issue 2741863002: DevTools: Focus background in Toolbars (Closed)
Patch Set: remove host-context Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
index db27ad535949a2dc47026408d4ddcbbdbebeb026..260b941565fe8244a8a3cee6c1e799a93696a466 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
@@ -745,8 +745,6 @@ UI.ToolbarMenuButton = class extends UI.ToolbarButton {
* @param {!Event} event
*/
_clicked(event) {
- if (!this._triggerTimeout)
pfeldman 2017/03/29 21:54:20 Why did this change?
- return;
clearTimeout(this._triggerTimeout);
this._trigger(event);
}
@@ -836,6 +834,7 @@ UI.ToolbarComboBox = class extends UI.ToolbarItem {
this._selectElement = this.element.createChild('select', 'toolbar-item');
var dropdownArrowIcon = UI.Icon.create('smallicon-triangle-down', 'toolbar-dropdown-arrow');
+
pfeldman 2017/03/29 21:54:20 Why did this change?
einbinder 2017/03/29 22:03:17 You caught me before I looked over the diff.
this.element.appendChild(dropdownArrowIcon);
if (changeHandler)
this._selectElement.addEventListener('change', changeHandler, false);

Powered by Google App Engine
This is Rietveld 408576698