Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Issue 2741863002: DevTools: Focus background in Toolbars (Closed)
Patch Set: raf Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
index 75ed17ce70855996d8d1c5d8aa825e5a35cf6006..7be313be2a622dbf674880f12297e506c003ac53 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
@@ -835,6 +835,8 @@ UI.ToolbarComboBox = class extends UI.ToolbarItem {
super(createElementWithClass('span', 'toolbar-select-container'));
this._selectElement = this.element.createChild('select', 'toolbar-item');
+ this._selectElement.addEventListener('focus', () => this.element.classList.add('focused'));
pfeldman 2017/03/27 21:17:35 why not :focused pseudo?
einbinder 2017/03/27 23:12:59 this._selectElement has focus, but this.element ne
+ this._selectElement.addEventListener('blur', () => this.element.classList.remove('focused'));
var dropdownArrowIcon = UI.Icon.create('smallicon-dropdown-arrow', 'toolbar-dropdown-arrow');
this.element.appendChild(dropdownArrowIcon);
if (changeHandler)

Powered by Google App Engine
This is Rietveld 408576698