DevTools: Focus background in Toolbars

third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 727 matching lines @@
     this._contextMenuHandler(contextMenu);
     contextMenu.show();
     this._lastTriggerTime = Date.now();
   }
 
   /**
    * @override
    * @param {!Event} event
    */
   _clicked(event) {
-    if (!this._triggerTimeout)

[pfeldman, 2017/03/29 21:54:20]

Why did this change?

-      return;
     clearTimeout(this._triggerTimeout);
     this._trigger(event);
   }
 };
 
 /**
  * @unrestricted
  */
 UI.ToolbarSettingToggle = class extends UI.ToolbarToggle {
   /**
@@ skipping 69 matching lines @@
 UI.ToolbarComboBox = class extends UI.ToolbarItem {
   /**
    * @param {?function(!Event)} changeHandler
    * @param {string=} className
    */
   constructor(changeHandler, className) {
     super(createElementWithClass('span', 'toolbar-select-container'));
 
     this._selectElement = this.element.createChild('select', 'toolbar-item');
     var dropdownArrowIcon = UI.Icon.create('smallicon-triangle-down', 'toolbar-dropdown-arrow');
+

[pfeldman, 2017/03/29 21:54:20]

Why did this change?

[einbinder, 2017/03/29 22:03:17]

You caught me before I looked over the diff.

     this.element.appendChild(dropdownArrowIcon);
     if (changeHandler)
       this._selectElement.addEventListener('change', changeHandler, false);
     if (className)
       this._selectElement.classList.add(className);
   }
 
   /**
    * @return {!HTMLSelectElement}
    */
@@ skipping 205 matching lines @@
   /**
    * @param {!Common.Setting} setting
    * @param {string=} tooltip
    * @param {string=} alternateTitle
    */
   constructor(setting, tooltip, alternateTitle) {
     super(alternateTitle || setting.title() || '', tooltip);
     UI.SettingsUI.bindCheckbox(this.inputElement, setting);
   }
 };