Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: net/net.gyp

Issue 274183002: Make it possible to build cronet without icu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Oops...add back file Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_util_unittest.cc ('k') | net/net.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/net.gyp
diff --git a/net/net.gyp b/net/net.gyp
index a454e7d6acd88f73d35f6a69efa1272d55ee9d0f..054d0661906d47b5988e5e3172947ddd14e7e9bc 100644
--- a/net/net.gyp
+++ b/net/net.gyp
@@ -439,8 +439,15 @@
},
],
[ 'use_icu_alternatives_on_android == 1', {
+ 'dependencies!': [
+ '../base/base.gyp:base_i18n',
+ '../third_party/icu/icu.gyp:icui18n',
+ '../third_party/icu/icu.gyp:icuuc',
+ ],
'sources!': [
+ 'base/filename_util_icu.cc',
'base/net_string_util_icu.cc',
+ 'base/net_util_icu.cc',
],
'sources': [
'base/net_string_util_icu_alternatives_android.cc',
@@ -641,7 +648,10 @@
],
},
],
- [ 'use_v8_in_net==1', {
+ # Always need use_v8_in_net to be 1 to run gyp on Android, so just
+ # remove net_unittest's dependency on v8 when using icu alternatives
+ # instead of setting use_v8_in_net to 0.
+ [ 'use_v8_in_net==1 and use_icu_alternatives_on_android==0', {
'dependencies': [
'net_with_v8',
],
@@ -749,10 +759,22 @@
},
],
['OS == "android" and gtest_target_type == "shared_library"', {
+ # TODO(mmenke): This depends on test_support_base, which depends on
+ # icu. Figure out a way to remove that dependency.
'dependencies': [
'../testing/android/native_test.gyp:native_test_native_code',
]
}],
+ [ 'use_icu_alternatives_on_android == 1', {
+ 'dependencies!': [
+ '../base/base.gyp:base_i18n',
+ ],
+ 'sources!': [
+ 'base/filename_util_unittest.cc',
+ 'base/net_util_icu_unittest.cc',
+ ],
+ },
+ ],
],
'target_conditions': [
# These source files are excluded by default platform rules, but they
@@ -823,6 +845,8 @@
],
'export_dependent_settings': [
'../base/base.gyp:base',
+ # TODO(mmenke): This depends on icu, figure out a way to build tests
+ # without icu.
'../base/base.gyp:test_support_base',
'../testing/gtest.gyp:gtest',
'../testing/gmock.gyp:gmock',
« no previous file with comments | « net/base/net_util_unittest.cc ('k') | net/net.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698