Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/physical_web/webui/physical_web_base_message_handler.h

Issue 2741823002: Update Physical Web WebUI to show new results automatically (Closed)
Patch Set: fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/physical_web/webui/physical_web_base_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/physical_web/webui/physical_web_base_message_handler.h
diff --git a/components/physical_web/webui/physical_web_base_message_handler.h b/components/physical_web/webui/physical_web_base_message_handler.h
index 190cf294b11f142fbfe0243aebc3881a11d2cd07..21b07cd08f5fb09c6ff0bc4fe9b253bdd4b91b66 100644
--- a/components/physical_web/webui/physical_web_base_message_handler.h
+++ b/components/physical_web/webui/physical_web_base_message_handler.h
@@ -5,9 +5,13 @@
#ifndef COMPONENTS_PHYSICAL_WEB_WEBUI_PHYSICAL_WEB_BASE_MESSAGE_HANDLER_H_
#define COMPONENTS_PHYSICAL_WEB_WEBUI_PHYSICAL_WEB_BASE_MESSAGE_HANDLER_H_
+#include <map>
+
#include "base/callback.h"
#include "base/macros.h"
#include "base/values.h"
+#include "components/physical_web/data_source/physical_web_data_source.h"
+#include "components/physical_web/data_source/physical_web_listener.h"
namespace physical_web {
@@ -22,14 +26,22 @@ typedef base::Callback<void(const base::ListValue*)> MessageCallback;
// The base handler for Javascript messages for the chrome://physical-web page.
// This does not implement WebUIMessageHandler or register its methods.
-class PhysicalWebBaseMessageHandler {
+class PhysicalWebBaseMessageHandler : physical_web::PhysicalWebListener {
public:
PhysicalWebBaseMessageHandler();
virtual ~PhysicalWebBaseMessageHandler();
- // Handles the RequestNearbyURLs message, returning URLs that are currently
- // being broadcasted by Physical Web transports.
- void HandleRequestNearbyURLs(const base::ListValue* args);
+ // PhysicalWebListener
+ void OnFound(const GURL& url) override;
+ void OnLost(const GURL& url) override;
+ void OnDistanceChanged(const GURL& url, double distance_estimate) override;
+
+ // Push URLs that are currently being broadcasted by Physical Web
+ // transports to WebUI.
+ void PushNearbyURLs();
+
+ // Push nearby URLs to WebUI and log UMA.
+ void HandlePhysicalWebPageLoaded(const base::ListValue* args);
// Handles a click on a Physical Web URL, recording the click and
// directing the user appropriately.
@@ -42,14 +54,17 @@ class PhysicalWebBaseMessageHandler {
// Subclasses should implement these protected methods as a pass through to
// the similarly named methods of the appropriate WebUI object (the exact
// WebUI class differs per platform).
- virtual void RegisterMessageCallback(
- const std::string& message,
- const MessageCallback& callback) = 0;
+ virtual void RegisterMessageCallback(const std::string& message,
+ const MessageCallback& callback) = 0;
virtual void CallJavaScriptFunction(const std::string& function,
const base::Value& arg) = 0;
virtual physical_web::PhysicalWebDataSource* GetPhysicalWebDataSource() = 0;
private:
+ physical_web::PhysicalWebDataSource* data_source_;
+ std::vector<std::string> ordered_group_ids_;
+ std::map<std::string, physical_web::Metadata> metadata_map_;
+
DISALLOW_COPY_AND_ASSIGN(PhysicalWebBaseMessageHandler);
};
« no previous file with comments | « no previous file | components/physical_web/webui/physical_web_base_message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698