Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Issue 2741803003: Print a helpful error message when observatory_tool.py encounters an error (Closed)

Created:
3 years, 9 months ago by Cutch
Modified:
3 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print a helpful error message when observatory_tool.py encounters an error BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/51f60482f9498120d25ef276e6aa6f7b532f7a04

Patch Set 1 #

Patch Set 2 : Always print failure messages #

Patch Set 3 : Undo latest change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M tools/observatory_tool.py View 2 4 chunks +35 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
3 years, 9 months ago (2017-03-09 23:36:28 UTC) #3
zra
lgtm
3 years, 9 months ago (2017-03-09 23:40:50 UTC) #4
Cutch
3 years, 9 months ago (2017-03-09 23:43:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
51f60482f9498120d25ef276e6aa6f7b532f7a04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698