third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h - Issue 2741723005: Move geometry interface files to geometry directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

Issue 2741723005: Move geometry interface files to geometry directory. (Closed)

Patch Set: Make WebkitCSSMatrix an alias of DOMMatrix DOMMatrix was changed sufficiently that WebKitCSSMatrix … Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

diff --git a/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h b/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

similarity index 100%

rename from third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h

rename to third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

index c78bfe50da335a02e5411f03f91910faa8aa748f..71a8e1321982c81db28f43761c99082ac660bb79 100644

--- a/third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h

+++ b/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h

@@ -5,12 +5,12 @@

#ifndef DOMMatrixReadOnly_h

#define DOMMatrixReadOnly_h

+#include <memory>

foolip 2017/03/14 14:38:43 Did a presubmit ask you to move <memory> up? AFAIC

zino 2017/03/22 16:08:40 Ah, please fix foolip@'s comment as well before la

Byoungkwon Ko 2017/03/23 17:03:19 Yes, As you told, presubmit ask me to move <memory

#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ScriptWrappable.h"

#include "core/dom/DOMTypedArray.h"

#include "platform/heap/Handle.h"

#include "platform/transforms/TransformationMatrix.h"

-#include <memory>

namespace blink {