Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: src/snapshot/deserializer.cc

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: [rename] Rename internal field to embedder field. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/snapshot/deserializer.h ('k') | src/snapshot/partial-serializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/deserializer.cc
diff --git a/src/snapshot/deserializer.cc b/src/snapshot/deserializer.cc
index 68e2716e6ff78e902358e8991a999f3939b39cd4..7a469b2f1d416b346d07a502e31f98117e00e2b2 100644
--- a/src/snapshot/deserializer.cc
+++ b/src/snapshot/deserializer.cc
@@ -121,7 +121,7 @@ void Deserializer::Deserialize(Isolate* isolate) {
MaybeHandle<Object> Deserializer::DeserializePartial(
Isolate* isolate, Handle<JSGlobalProxy> global_proxy,
- v8::DeserializeInternalFieldsCallback internal_fields_deserializer) {
+ v8::DeserializeEmbedderFieldsCallback embedder_fields_deserializer) {
Initialize(isolate);
if (!ReserveSpace()) {
V8::FatalProcessOutOfMemory("deserialize context");
@@ -138,7 +138,7 @@ MaybeHandle<Object> Deserializer::DeserializePartial(
Object* root;
VisitPointer(&root);
DeserializeDeferredObjects();
- DeserializeInternalFields(internal_fields_deserializer);
+ DeserializeEmbedderFields(embedder_fields_deserializer);
isolate->heap()->RegisterReservationsForBlackAllocation(reservations_);
@@ -225,13 +225,13 @@ void Deserializer::DeserializeDeferredObjects() {
}
}
-void Deserializer::DeserializeInternalFields(
- v8::DeserializeInternalFieldsCallback internal_fields_deserializer) {
- if (!source_.HasMore() || source_.Get() != kInternalFieldsData) return;
+void Deserializer::DeserializeEmbedderFields(
+ v8::DeserializeEmbedderFieldsCallback embedder_fields_deserializer) {
+ if (!source_.HasMore() || source_.Get() != kEmbedderFieldsData) return;
DisallowHeapAllocation no_gc;
DisallowJavascriptExecution no_js(isolate_);
DisallowCompilation no_compile(isolate_);
- DCHECK_NOT_NULL(internal_fields_deserializer.callback);
+ DCHECK_NOT_NULL(embedder_fields_deserializer.callback);
for (int code = source_.Get(); code != kSynchronize; code = source_.Get()) {
HandleScope scope(isolate_);
int space = code & kSpaceMask;
@@ -243,9 +243,9 @@ void Deserializer::DeserializeInternalFields(
int size = source_.GetInt();
byte* data = new byte[size];
source_.CopyRaw(data, size);
- internal_fields_deserializer.callback(v8::Utils::ToLocal(obj), index,
+ embedder_fields_deserializer.callback(v8::Utils::ToLocal(obj), index,
{reinterpret_cast<char*>(data), size},
- internal_fields_deserializer.data);
+ embedder_fields_deserializer.data);
delete[] data;
}
}
« no previous file with comments | « src/snapshot/deserializer.h ('k') | src/snapshot/partial-serializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698