Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: [rename] Rename internal field to embedder field. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-typedarray-gen.cc ('k') | src/d8.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index f0caf1bd8ec0bac02c20d7426d45a58dab89806b..071a67a8d922c935fd901f161d1954d89ea66ec2 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -9879,7 +9879,7 @@ HValue* HGraphBuilder::BuildAllocateEmptyArrayBuffer(HValue* byte_length) {
byte_length = AddUncasted<HForceRepresentation>(
byte_length, byte_length_access.representation());
HAllocate* result =
- BuildAllocate(Add<HConstant>(JSArrayBuffer::kSizeWithInternalFields),
+ BuildAllocate(Add<HConstant>(JSArrayBuffer::kSizeWithEmbedderFields),
HType::JSObject(), JS_ARRAY_BUFFER_TYPE, HAllocationMode());
HValue* native_context = BuildGetNativeContext();
@@ -9909,7 +9909,7 @@ HValue* HGraphBuilder::BuildAllocateEmptyArrayBuffer(HValue* byte_length) {
Add<HConstant>((1 << JSArrayBuffer::IsExternal::kShift) |
(1 << JSArrayBuffer::IsNeuterable::kShift)));
- for (int field = 0; field < v8::ArrayBuffer::kInternalFieldCount; ++field) {
+ for (int field = 0; field < v8::ArrayBuffer::kEmbedderFieldCount; ++field) {
Add<HStoreNamedField>(
result,
HObjectAccess::ForObservableJSObjectOffset(
@@ -9927,10 +9927,8 @@ void HGraphBuilder::BuildArrayBufferViewInitialization(
HValue* buffer,
HValue* byte_offset,
HValue* byte_length) {
-
for (int offset = ViewClass::kSize;
- offset < ViewClass::kSizeWithInternalFields;
- offset += kPointerSize) {
+ offset < ViewClass::kSizeWithEmbedderFields; offset += kPointerSize) {
Add<HStoreNamedField>(obj,
HObjectAccess::ForObservableJSObjectOffset(offset),
graph()->GetConstant0());
« no previous file with comments | « src/builtins/builtins-typedarray-gen.cc ('k') | src/d8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698