Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: src/wasm/wasm-objects.h

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: Remove API changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-objects.h
diff --git a/src/wasm/wasm-objects.h b/src/wasm/wasm-objects.h
index 3c7ef4f2e16a5907e7f8ad296ba030eb004a91ea..2c210c9f30d233977d80b9b93ff003e2b5342f06 100644
--- a/src/wasm/wasm-objects.h
+++ b/src/wasm/wasm-objects.h
@@ -45,7 +45,7 @@ class WasmInstanceWrapper;
class WasmModuleObject : public JSObject {
public:
// If a second field is added, we need a kWrapperTracerHeader field as well.
- // TODO(titzer): add the brand as an internal field instead of a property.
+ // TODO(titzer): add the brand as an embedder field instead of a property.
enum Fields { kCompiledModule, kFieldCount };
DECLARE_CASTS(WasmModuleObject);
@@ -60,7 +60,7 @@ class WasmModuleObject : public JSObject {
class WasmTableObject : public JSObject {
public:
// The 0-th field is used by the Blink Wrapper Tracer.
- // TODO(titzer): add the brand as an internal field instead of a property.
+ // TODO(titzer): add the brand as an embedder field instead of a property.
enum Fields {
kWrapperTracerHeader,
kFunctions,
@@ -92,7 +92,7 @@ class WasmTableObject : public JSObject {
class WasmMemoryObject : public JSObject {
public:
// The 0-th field is used by the Blink Wrapper Tracer.
- // TODO(titzer): add the brand as an internal field instead of a property.
+ // TODO(titzer): add the brand as an embedder field instead of a property.
enum Fields : uint8_t {
kWrapperTracerHeader,
kArrayBuffer,
@@ -123,7 +123,7 @@ class WasmMemoryObject : public JSObject {
class WasmInstanceObject : public JSObject {
public:
// The 0-th field is used by the Blink Wrapper Tracer.
- // TODO(titzer): add the brand as an internal field instead of a property.
+ // TODO(titzer): add the brand as an embedder field instead of a property.
enum Fields {
kWrapperTracerHeader,
kCompiledModule,
« src/objects.h ('K') | « src/wasm/wasm-module.cc ('k') | src/wasm/wasm-objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698