Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/fast-accessor-assembler.h

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: DEPRECATE_SOON(GetInternalField) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_FAST_ACCESSOR_ASSEMBLER_H_ 5 #ifndef V8_FAST_ACCESSOR_ASSEMBLER_H_
6 #define V8_FAST_ACCESSOR_ASSEMBLER_H_ 6 #define V8_FAST_ACCESSOR_ASSEMBLER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <memory> 9 #include <memory>
10 #include <vector> 10 #include <vector>
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 typedef v8::experimental::FastAccessorBuilder::ValueId ValueId; 48 typedef v8::experimental::FastAccessorBuilder::ValueId ValueId;
49 typedef v8::experimental::FastAccessorBuilder::LabelId LabelId; 49 typedef v8::experimental::FastAccessorBuilder::LabelId LabelId;
50 typedef v8::FunctionCallback FunctionCallback; 50 typedef v8::FunctionCallback FunctionCallback;
51 51
52 explicit FastAccessorAssembler(Isolate* isolate); 52 explicit FastAccessorAssembler(Isolate* isolate);
53 ~FastAccessorAssembler(); 53 ~FastAccessorAssembler();
54 54
55 // Builder / assembler functions: 55 // Builder / assembler functions:
56 ValueId IntegerConstant(int int_constant); 56 ValueId IntegerConstant(int int_constant);
57 ValueId GetReceiver(); 57 ValueId GetReceiver();
58 ValueId LoadInternalField(ValueId value_id, int field_no); 58 ValueId LoadEmbedderField(ValueId value_id, int field_no);
59 59
60 // Loads internal field and assumes the object is indeed a valid API object 60 // Loads embedder field and assumes the object is indeed a valid API object
61 // with the proper internal fields present. 61 // with the proper embedder fields present.
62 // The intended use is to call this on an object whose structure has already 62 // The intended use is to call this on an object whose structure has already
63 // been checked previously, e.g. the accessor's receiver, which is map-checked 63 // been checked previously, e.g. the accessor's receiver, which is map-checked
64 // before the fast accessor is called on it. Using this on an arbitrary object 64 // before the fast accessor is called on it. Using this on an arbitrary object
65 // will result in unsafe memory accesses. 65 // will result in unsafe memory accesses.
66 ValueId LoadInternalFieldUnchecked(ValueId value_id, int field_no); 66 ValueId LoadEmbedderFieldUnchecked(ValueId value_id, int field_no);
67 67
68 ValueId LoadValue(ValueId value_id, int offset); 68 ValueId LoadValue(ValueId value_id, int offset);
69 ValueId LoadObject(ValueId value_id, int offset); 69 ValueId LoadObject(ValueId value_id, int offset);
70 70
71 // Converts a machine integer to a SMI. 71 // Converts a machine integer to a SMI.
72 ValueId ToSmi(ValueId value_id); 72 ValueId ToSmi(ValueId value_id);
73 73
74 // Builder / assembler functions for control flow. 74 // Builder / assembler functions for control flow.
75 void ReturnValue(ValueId value_id); 75 void ReturnValue(ValueId value_id);
76 void CheckFlagSetOrReturnNull(ValueId value_id, int mask); 76 void CheckFlagSetOrReturnNull(ValueId value_id, int mask);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 // strict as this class will be exposed at the API.) 113 // strict as this class will be exposed at the API.)
114 enum { kBuilding, kBuilt, kError } state_; 114 enum { kBuilding, kBuilt, kError } state_;
115 115
116 DISALLOW_COPY_AND_ASSIGN(FastAccessorAssembler); 116 DISALLOW_COPY_AND_ASSIGN(FastAccessorAssembler);
117 }; 117 };
118 118
119 } // namespace internal 119 } // namespace internal
120 } // namespace v8 120 } // namespace v8
121 121
122 #endif // V8_FAST_ACCESSOR_ASSEMBLER_H_ 122 #endif // V8_FAST_ACCESSOR_ASSEMBLER_H_
OLDNEW
« include/v8-experimental.h ('K') | « src/factory.cc ('k') | src/fast-accessor-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698