Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: test/cctest/test-api.cc

Side-by-side diff isn't available for this file because of its large size.
Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: [rename] Rename internal field to embedder field. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « src/wasm/wasm-objects.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index cc3d15ea4484016354e063a8a4af083a5eaff6d8..85e877fc0d713d31d7fb555d68b096e5bdff5d72 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -2624,7 +2624,6 @@ THREADED_TEST(FunctionPrototype) {
CHECK_EQ(v8_run_int32value(script), 321);
}
-
THREADED_TEST(InternalFields) {
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
@@ -2643,7 +2642,6 @@ THREADED_TEST(InternalFields) {
CHECK_EQ(17, obj->GetInternalField(0)->Int32Value(env.local()).FromJust());
}
-
THREADED_TEST(GlobalObjectInternalFields) {
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate);
@@ -2668,7 +2666,6 @@ THREADED_TEST(GlobalObjectHasRealIndexedProperty) {
CHECK(global->HasRealIndexedProperty(env.local(), 0).FromJust());
}
-
static void CheckAlignedPointerInInternalField(Local<v8::Object> obj,
void* value) {
CHECK_EQ(0, static_cast<int>(reinterpret_cast<uintptr_t>(value) & 0x1));
@@ -2677,7 +2674,6 @@ static void CheckAlignedPointerInInternalField(Local<v8::Object> obj,
CHECK_EQ(value, obj->GetAlignedPointerFromInternalField(0));
}
-
THREADED_TEST(InternalFieldsAlignedPointers) {
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
@@ -7547,7 +7543,6 @@ class Trivial2 {
int x_;
};
-
void CheckInternalFields(
const v8::WeakCallbackInfo<v8::Persistent<v8::Object>>& data) {
v8::Persistent<v8::Object>* handle = data.GetParameter();
@@ -7560,7 +7555,6 @@ void CheckInternalFields(
t2->set_x(33550336);
}
-
void InternalFieldCallback(bool global_gc) {
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
@@ -7612,7 +7606,6 @@ void InternalFieldCallback(bool global_gc) {
delete t2;
}
-
THREADED_TEST(InternalFieldCallback) {
InternalFieldCallback(false);
InternalFieldCallback(true);
@@ -14599,9 +14592,8 @@ TEST(Regress51719) {
isolate->AdjustAmountOfExternalAllocatedMemory(kTriggerGCSize);
}
-
-// Regression test for issue 54, object templates with internal fields
-// but no accessors or interceptors did not get their internal field
+// Regression test for issue 54, object templates with embedder fields
+// but no accessors or interceptors did not get their embedder field
// count set on instances.
THREADED_TEST(Regress54) {
LocalContext context;
@@ -16683,7 +16675,6 @@ THREADED_TEST(SharedDataView) {
CHECK(ab->Equals(env.local(), dv->Buffer()).FromJust());
}
-
#define IS_ARRAY_BUFFER_VIEW_TEST(View) \
THREADED_TEST(Is##View) { \
LocalContext env; \
« no previous file with comments | « src/wasm/wasm-objects.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698