Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/debug/debug.cc

Issue 2741683004: [rename] Rename internal field to embedder field. (Closed)
Patch Set: [rename] Rename internal field to embedder field. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/d8.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/arguments.h" 10 #include "src/arguments.h"
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 451
452 // Create the debugger context. 452 // Create the debugger context.
453 HandleScope scope(isolate_); 453 HandleScope scope(isolate_);
454 ExtensionConfiguration no_extensions; 454 ExtensionConfiguration no_extensions;
455 // TODO(yangguo): we rely on the fact that first context snapshot is usable 455 // TODO(yangguo): we rely on the fact that first context snapshot is usable
456 // as debug context. This dependency is gone once we remove 456 // as debug context. This dependency is gone once we remove
457 // debug context completely. 457 // debug context completely.
458 static const int kFirstContextSnapshotIndex = 0; 458 static const int kFirstContextSnapshotIndex = 0;
459 Handle<Context> context = isolate_->bootstrapper()->CreateEnvironment( 459 Handle<Context> context = isolate_->bootstrapper()->CreateEnvironment(
460 MaybeHandle<JSGlobalProxy>(), v8::Local<ObjectTemplate>(), &no_extensions, 460 MaybeHandle<JSGlobalProxy>(), v8::Local<ObjectTemplate>(), &no_extensions,
461 kFirstContextSnapshotIndex, v8::DeserializeInternalFieldsCallback(), 461 kFirstContextSnapshotIndex, v8::DeserializeEmbedderFieldsCallback(),
462 DEBUG_CONTEXT); 462 DEBUG_CONTEXT);
463 463
464 // Fail if no context could be created. 464 // Fail if no context could be created.
465 if (context.is_null()) return false; 465 if (context.is_null()) return false;
466 466
467 debug_context_ = Handle<Context>::cast( 467 debug_context_ = Handle<Context>::cast(
468 isolate_->global_handles()->Create(*context)); 468 isolate_->global_handles()->Create(*context));
469 469
470 feature_tracker()->Track(DebugFeatureTracker::kActive); 470 feature_tracker()->Track(DebugFeatureTracker::kActive);
471 471
(...skipping 1984 matching lines...) Expand 10 before | Expand all | Expand 10 after
2456 isolate_->Throw(*isolate_->factory()->NewEvalError( 2456 isolate_->Throw(*isolate_->factory()->NewEvalError(
2457 MessageTemplate::kNoSideEffectDebugEvaluate)); 2457 MessageTemplate::kNoSideEffectDebugEvaluate));
2458 } 2458 }
2459 isolate_->set_needs_side_effect_check(old_needs_side_effect_check_); 2459 isolate_->set_needs_side_effect_check(old_needs_side_effect_check_);
2460 isolate_->debug()->UpdateHookOnFunctionCall(); 2460 isolate_->debug()->UpdateHookOnFunctionCall();
2461 isolate_->debug()->side_effect_check_failed_ = false; 2461 isolate_->debug()->side_effect_check_failed_ = false;
2462 } 2462 }
2463 2463
2464 } // namespace internal 2464 } // namespace internal
2465 } // namespace v8 2465 } // namespace v8
OLDNEW
« no previous file with comments | « src/d8.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698