Issue 274163002: Harden %SetIsObserved with RUNTIME_ASSERTs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274163002: Harden %SetIsObserved with RUNTIME_ASSERTs (Closed)

Created:
6 years, 7 months ago by adamk

Modified:
6 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, rossberg, rafaelw

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Harden %SetIsObserved with RUNTIME_ASSERTs Now throws if its argument is already observed, or if the argument is the global proxy. BUG=371782 LOG=Y R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21256

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed lint #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
	M	src/runtime.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
	A	test/mjsunit/es7/object-observe-runtime.js	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. https://codereview.chromium.org/274163002/diff/1/test/mjsunit/es7/object-observe-runtime.js File test/mjsunit/es7/object-observe-runtime.js (right): https://codereview.chromium.org/274163002/diff/1/test/mjsunit/es7/object-observe-runtime.js#newcode7 test/mjsunit/es7/object-observe-runtime.js:7: // These tests are meant ...

6 years, 7 months ago (2014-05-12 08:32:38 UTC) #2

adamk

Committed patchset #2 manually as r21256 (presubmit successful).

6 years, 7 months ago (2014-05-12 08:50:00 UTC) #3

adamk

6 years, 7 months ago (2014-05-12 08:55:06 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/274163002/diff/1/test/mjsunit/es7/object-obse...
File test/mjsunit/es7/object-observe-runtime.js (right):

https://codereview.chromium.org/274163002/diff/1/test/mjsunit/es7/object-obse...
test/mjsunit/es7/object-observe-runtime.js:7: // These tests are meant to ensure
that that the Object.observe runtime functions
On 2014/05/12 08:32:39, Jakob wrote:
> nit: 80col

Done.

Expand Messages | Collapse Messages