Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: runtime/vm/code_patcher_ia32.cc

Issue 2741553002: Do not rely on code patching on DBC for lazy deoptimization. (Closed)
Patch Set: Code review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/code_patcher_dbc.cc ('k') | runtime/vm/code_patcher_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_patcher.h" 9 #include "vm/code_patcher.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 const Code& code, 163 const Code& code,
164 const Code& new_target) { 164 const Code& new_target) {
165 const Instructions& instrs = Instructions::Handle(code.instructions()); 165 const Instructions& instrs = Instructions::Handle(code.instructions());
166 WritableInstructionsScope writable(instrs.PayloadStart(), instrs.Size()); 166 WritableInstructionsScope writable(instrs.PayloadStart(), instrs.Size());
167 ASSERT(code.ContainsInstructionAt(return_address)); 167 ASSERT(code.ContainsInstructionAt(return_address));
168 StaticCall call(return_address); 168 StaticCall call(return_address);
169 call.set_target(new_target); 169 call.set_target(new_target);
170 } 170 }
171 171
172 172
173 void CodePatcher::InsertDeoptimizationCallAt(uword start) {
174 UNREACHABLE();
175 }
176
177
178 RawCode* CodePatcher::GetInstanceCallAt(uword return_address, 173 RawCode* CodePatcher::GetInstanceCallAt(uword return_address,
179 const Code& code, 174 const Code& code,
180 ICData* ic_data) { 175 ICData* ic_data) {
181 ASSERT(code.ContainsInstructionAt(return_address)); 176 ASSERT(code.ContainsInstructionAt(return_address));
182 InstanceCall call(return_address); 177 InstanceCall call(return_address);
183 if (ic_data != NULL) { 178 if (ic_data != NULL) {
184 *ic_data ^= call.ic_data(); 179 *ic_data ^= call.ic_data();
185 } 180 }
186 return Code::null(); 181 return Code::null();
187 } 182 }
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 } 237 }
243 238
244 239
245 intptr_t CodePatcher::InstanceCallSizeInBytes() { 240 intptr_t CodePatcher::InstanceCallSizeInBytes() {
246 return InstanceCall::kPatternSize; 241 return InstanceCall::kPatternSize;
247 } 242 }
248 243
249 } // namespace dart 244 } // namespace dart
250 245
251 #endif // defined TARGET_ARCH_IA32 246 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/code_patcher_dbc.cc ('k') | runtime/vm/code_patcher_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698