Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: tools/perf/PRESUBMIT.py

Issue 2741533003: [Telemetry] Move from telemetry/trace_data to tracing/trace_data in chromium (Closed)
Patch Set: renable test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for changes affecting tools/perf/. 5 """Presubmit script for changes affecting tools/perf/.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 14 matching lines...) Expand all
25 return results 25 return results
26 26
27 27
28 def _GetPathsToPrepend(input_api): 28 def _GetPathsToPrepend(input_api):
29 perf_dir = input_api.PresubmitLocalPath() 29 perf_dir = input_api.PresubmitLocalPath()
30 chromium_src_dir = input_api.os_path.join(perf_dir, '..', '..') 30 chromium_src_dir = input_api.os_path.join(perf_dir, '..', '..')
31 telemetry_dir = input_api.os_path.join( 31 telemetry_dir = input_api.os_path.join(
32 chromium_src_dir, 'third_party', 'catapult', 'telemetry') 32 chromium_src_dir, 'third_party', 'catapult', 'telemetry')
33 experimental_dir = input_api.os_path.join( 33 experimental_dir = input_api.os_path.join(
34 chromium_src_dir, 'third_party', 'catapult', 'experimental') 34 chromium_src_dir, 'third_party', 'catapult', 'experimental')
35 tracing_dir = input_api.os_path.join(
36 chromium_src_dir, 'third_party', 'catapult', 'tracing')
35 return [ 37 return [
36 telemetry_dir, 38 telemetry_dir,
37 input_api.os_path.join(telemetry_dir, 'third_party', 'mock'), 39 input_api.os_path.join(telemetry_dir, 'third_party', 'mock'),
38 experimental_dir, 40 experimental_dir,
41 tracing_dir,
39 ] 42 ]
40 43
41 44
42 def _RunArgs(args, input_api): 45 def _RunArgs(args, input_api):
43 p = input_api.subprocess.Popen(args, stdout=input_api.subprocess.PIPE, 46 p = input_api.subprocess.Popen(args, stdout=input_api.subprocess.PIPE,
44 stderr=input_api.subprocess.STDOUT) 47 stderr=input_api.subprocess.STDOUT)
45 out, _ = p.communicate() 48 out, _ = p.communicate()
46 return (out, p.returncode) 49 return (out, p.returncode)
47 50
48 51
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 def CheckChangeOnUpload(input_api, output_api): 112 def CheckChangeOnUpload(input_api, output_api):
110 report = [] 113 report = []
111 report.extend(_CommonChecks(input_api, output_api)) 114 report.extend(_CommonChecks(input_api, output_api))
112 return report 115 return report
113 116
114 117
115 def CheckChangeOnCommit(input_api, output_api): 118 def CheckChangeOnCommit(input_api, output_api):
116 report = [] 119 report = []
117 report.extend(_CommonChecks(input_api, output_api)) 120 report.extend(_CommonChecks(input_api, output_api))
118 return report 121 return report
OLDNEW
« no previous file with comments | « tools/chrome_proxy/common/inspector_network.py ('k') | tools/perf/measurements/clock_domain_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698