Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/Database.h

Issue 2741443003: Replace createCrossThreadTask with crossThreadBind in webdatabase (Closed)
Patch Set: Save WebTaskRunner in main thread and use it later in another thread Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webdatabase/Database.h
diff --git a/third_party/WebKit/Source/modules/webdatabase/Database.h b/third_party/WebKit/Source/modules/webdatabase/Database.h
index 77aa67586a9ac808058cc59804ec167aa4d20273..c1b7a20513115448eaa67a28ad00f7965adad84c 100644
--- a/third_party/WebKit/Source/modules/webdatabase/Database.h
+++ b/third_party/WebKit/Source/modules/webdatabase/Database.h
@@ -115,6 +115,7 @@ class Database final : public GarbageCollectedFinalized<Database>,
return m_databaseContext.get();
}
ExecutionContext* getExecutionContext() const;
+ RefPtr<WebTaskRunner> getWebTaskRunner() const;
nhiroki 2017/03/09 07:59:56 getDatabaseTaskRunenr()? Can you return WebTaskRu
yuryu 2017/03/09 08:38:27 Done.
private:
class DatabaseOpenTask;
@@ -176,6 +177,9 @@ class Database final : public GarbageCollectedFinalized<Database>,
RefPtr<SecurityOrigin> m_databaseThreadSecurityOrigin;
Member<DatabaseContext>
m_databaseContext; // Associated with m_executionContext.
+ // TaskRunnerHelper::get is not thread-safe, so we save WebTaskRunner
+ // for later use as the constructor runs in the main thread.
+ RefPtr<WebTaskRunner> m_webTaskRunner;
nhiroki 2017/03/09 07:59:56 How about m_databaseTaskRunner? It could be cleare
yuryu 2017/03/09 08:38:27 Done.
String m_name;
String m_expectedVersion;

Powered by Google App Engine
This is Rietveld 408576698