Temporarily Making Server-Side NTP Recommendations Use LINK Transition Instead of AUTO_BOOKMARK

Temporarily Making Server-Side NTP Recommendations Use LINK Transition Instead of AUTO_BOOKMARK

Previously "NTP clicks" (i.e., navigations on NTP suggestions) use AUTO_BOOKMARK transition type. Eventually we want to create a new transition type, but right now AUTO_BOOKMARK ambiguates NTP clicks with bookmark usage.  To prevent this, this CL make NTP clicks for *server-side suggestions* a LINK transition type.  This partially reverts the changes for https://chromiumcodereview.appspot.com/178253008/ .

Important: NTP clicks for client-side recommendations (i.e., Most Visited) remains at AUTO_BOOKMARK, as to not interfere with existing behavior in chain start detection.

BUG=374960
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269658

[huangs, 2014-05-09 16:00:51]

Small change but too a while to test.  PTAL.

[beaudoin, 2014-05-09 17:40:51]

LGTM feels safer than the previous change.

[huangs, 2014-05-09 17:47:55]

OWNER review to jered@. Barring objections, we'd like to get the small change in
before the cut.  Thanks!

[Jered, 2014-05-09 17:52:28]

On 2014/05/09 17:47:55, huangs1 wrote:
> OWNER review to jered@. Barring objections, we'd like to get the small change
in
> before the cut.  Thanks!

lgtm

[huangs, 2014-05-09 20:45:45]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-05-09 20:49:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/huangs@chromium.org/274143002/1

[huangs, 2014-05-09 21:35:27]

The CQ bit was unchecked by huangs@chromium.org

[huangs, 2014-05-09 21:35:33]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-05-09 21:42:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/huangs@chromium.org/274143002/1

[huangs, 2014-05-09 22:47:35]

The CQ bit was unchecked by huangs@chromium.org

[huangs, 2014-05-09 22:47:40]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-05-09 22:52:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/huangs@chromium.org/274143002/1

[commit-bot: I haz the power, 2014-05-11 00:46:36]

Change committed as 269658