ios/web_view/internal/cwv_web_view.mm - Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web_view/internal/cwv_web_view.mm

Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController. (Closed)

Patch Set: Rebase and Remove DCHECK in |loadWithParams| as it has already been taken care of Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web_view/internal/cwv_web_view.mm

diff --git a/ios/web_view/internal/cwv_web_view.mm b/ios/web_view/internal/cwv_web_view.mm

index 383dc77f8393615b4037bc136e64198f19423f04..08fb97d0cad8000af7e293c22ba15bca521b574e 100644

--- a/ios/web_view/internal/cwv_web_view.mm

+++ b/ios/web_view/internal/cwv_web_view.mm

@@ -132,7 +132,10 @@ - (void)goForward {

}

- (void)reload {

- _webState->GetNavigationManager()->Reload(web::ReloadType::NORMAL, true);

+ // |check_for_repost| is false because CWVWebView does not support repost form

+ // dialogs.

+ _webState->GetNavigationManager()->Reload(web::ReloadType::NORMAL,

+ false /* check_for_repost */);

}

- (void)stopLoading {

« no previous file with comments | « ios/web/web_state/web_state_impl.mm ('k') | no next file » | no next file with comments »