Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: ios/web/navigation/navigation_manager_impl.mm

Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController. (Closed)
Patch Set: Rebase and Remove DCHECK in |loadWithParams| as it has already been taken care of Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/navigation_manager_impl.mm
diff --git a/ios/web/navigation/navigation_manager_impl.mm b/ios/web/navigation/navigation_manager_impl.mm
index 41454efe306c8d2362ce2a91af245e2fceb0df81..bf3c484e69ad9ae44f435fc96276505ca243c9d0 100644
--- a/ios/web/navigation/navigation_manager_impl.mm
+++ b/ios/web/navigation/navigation_manager_impl.mm
@@ -348,16 +348,7 @@ bool AreURLsInPageNavigation(const GURL& existing_url, const GURL& new_url) {
void NavigationManagerImpl::Reload(ReloadType reload_type,
bool check_for_reposts) {
- // Navigation manager may be empty if the only pending item failed to load
- // with SSL error and the user has decided not to proceed.
- NavigationItem* item = GetVisibleItem();
- GURL url = item ? item->GetURL() : GURL(url::kAboutBlankURL);
- web::Referrer referrer = item ? item->GetReferrer() : web::Referrer();
-
- WebState::OpenURLParams params(url, referrer,
- WindowOpenDisposition::CURRENT_TAB,
- ui::PAGE_TRANSITION_RELOAD, NO);
- delegate_->GetWebState()->OpenURL(params);
+ delegate_->Reload();
}
void NavigationManagerImpl::CopyStateFromAndPrune(
« no previous file with comments | « ios/web/navigation/navigation_manager_delegate.h ('k') | ios/web/navigation/navigation_manager_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698