Refactoring Reload in NavigationManager and CRWWebController.

ios/web/navigation/navigation_manager_impl_unittest.mm

Index: ios/web/navigation/navigation_manager_impl_unittest.mm
diff --git a/ios/web/navigation/navigation_manager_impl_unittest.mm b/ios/web/navigation/navigation_manager_impl_unittest.mm
index 38394c937603ad695921d37fd62384cc3dc0aa05..ead0757a264c035dd8e81af0548c9d87a41ddec7 100644
--- a/ios/web/navigation/navigation_manager_impl_unittest.mm
+++ b/ios/web/navigation/navigation_manager_impl_unittest.mm
@@ -20,6 +20,7 @@
 class TestNavigationManagerDelegate : public NavigationManagerDelegate {
   void GoToIndex(int index) override {}
   void LoadURLWithParams(const NavigationManager::WebLoadParams&) override {}
+  void Reload() override {}
   void OnNavigationItemsPruned(size_t pruned_item_count) override {}
   void OnNavigationItemChanged() override{};
   void OnNavigationItemCommitted(const LoadCommittedDetails&) override {}
@@ -598,4 +599,20 @@ void OnNavigationItemCommitted(const LoadCommittedDetails&) override {}
   EXPECT_EQ(item2->GetUserAgentType(), item3->GetUserAgentType());
 }
 
+// Tests that calling |Reload| on NavigationManager leaves the Url of the
+// visible item unchanged.
+TEST_F(NavigationManagerTest, ReloadWithNormalReloadType) {
+  navigation_manager()->AddPendingItem(
+      GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+      web::NavigationInitiationType::USER_INITIATED);
+  ASSERT_TRUE(navigation_manager()->GetVisibleItem());
+
+  GURL url_before_reload = navigation_manager()->GetVisibleItem()->GetURL();
+  navigation_manager()->Reload(web::ReloadType::NORMAL,
+                               true /* check_for_repost */);

[Eugene But (OOO till 7-30), 2017/03/16 17:17:47]

s/true/false so this test does not fail when form repost dialog is implemented
for reloads

[liaoyuke, 2017/03/16 18:10:42]

Done.

+
+  EXPECT_EQ(url_before_reload,
+            navigation_manager()->GetVisibleItem()->GetURL());
+}
+
 }  // namespace web