Refactoring Reload in NavigationManager and CRWWebController.

ios/web/web_state/ui/crw_web_controller.mm

Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 81dd6e629220c078b2e7d23b102f4c48005a254e..d03ed0cea5bfd6c25680210d12ba630b53e82511 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -1844,6 +1844,12 @@ - (void)loadCurrentURLInNativeView {
 }
 
 - (void)loadWithParams:(const NavigationManager::WebLoadParams&)originalParams {
+  if (PageTransitionCoreTypeIs(originalParams.transition_type,
+                               ui::PAGE_TRANSITION_RELOAD)) {

[Eugene But (OOO till 7-30), 2017/03/15 17:53:32]

This changes the way how NavigationManager::LoadURLWithParams (public web API)
works by ignoring all WebLoadParams except originalParams.transition_type. Is
this new behavior the same as content behavior?

[kkhorimoto, 2017/03/15 18:04:11]

This doesn't actually change how we handle |originalParams|, since the RELOAD
page transition type goes through the "if (forwardBack)" condition below, where
we aren't actually adding a new NavigationItem.  Going through reload instead of
the old flow goes through |-reloadInternal|, allowing us to A) properly record
the reload UMA, B) behave correctly for reloads during interstitials, and C)
call the native controller's |-reload| instead of creating a new native
controller.  I'm not sure exactly if using the transition type and ignoring the
URLs in the params is correct, but this seems like a step in the right
direction.

[Eugene But (OOO till 7-30), 2017/03/15 18:07:10]

Thanks! If current behavior is preserved then we don't need to look into
content.

+    [self reload];
+    return;
+  }
+
   // Make a copy of |params|, as some of the delegate methods may modify it.
   NavigationManager::WebLoadParams params(originalParams);