ios/web/web_state/ui/crw_web_controller.mm - Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController. (Closed)

Patch Set: Addressed high level comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index 81dd6e629220c078b2e7d23b102f4c48005a254e..d03ed0cea5bfd6c25680210d12ba630b53e82511 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -1844,6 +1844,12 @@ - (void)loadCurrentURLInNativeView {

}

- (void)loadWithParams:(const NavigationManager::WebLoadParams&)originalParams {

+ if (PageTransitionCoreTypeIs(originalParams.transition_type,

+ ui::PAGE_TRANSITION_RELOAD)) {

+ [self reload];

+ return;

+ }

// Make a copy of |params|, as some of the delegate methods may modify it.

NavigationManager::WebLoadParams params(originalParams);