Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: ios/web/web_state/web_state_impl.mm

Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController. (Closed)
Patch Set: Rebase and Remove DCHECK in |loadWithParams| as it has already been taken care of Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/web_state/web_state_impl.h ('k') | ios/web_view/internal/cwv_web_view.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/web_state/web_state_impl.h" 5 #import "ios/web/web_state/web_state_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 736
737 void WebStateImpl::GoToIndex(int index) { 737 void WebStateImpl::GoToIndex(int index) {
738 [web_controller_ goToItemAtIndex:index]; 738 [web_controller_ goToItemAtIndex:index];
739 } 739 }
740 740
741 void WebStateImpl::LoadURLWithParams( 741 void WebStateImpl::LoadURLWithParams(
742 const NavigationManager::WebLoadParams& params) { 742 const NavigationManager::WebLoadParams& params) {
743 [web_controller_ loadWithParams:params]; 743 [web_controller_ loadWithParams:params];
744 } 744 }
745 745
746 void WebStateImpl::Reload() {
747 [web_controller_ reload];
748 }
749
746 void WebStateImpl::OnNavigationItemsPruned(size_t pruned_item_count) { 750 void WebStateImpl::OnNavigationItemsPruned(size_t pruned_item_count) {
747 for (auto& observer : observers_) 751 for (auto& observer : observers_)
748 observer.NavigationItemsPruned(pruned_item_count); 752 observer.NavigationItemsPruned(pruned_item_count);
749 } 753 }
750 754
751 void WebStateImpl::OnNavigationItemChanged() { 755 void WebStateImpl::OnNavigationItemChanged() {
752 for (auto& observer : observers_) 756 for (auto& observer : observers_)
753 observer.NavigationItemChanged(); 757 observer.NavigationItemChanged();
754 } 758 }
755 759
756 void WebStateImpl::OnNavigationItemCommitted( 760 void WebStateImpl::OnNavigationItemCommitted(
757 const LoadCommittedDetails& load_details) { 761 const LoadCommittedDetails& load_details) {
758 for (auto& observer : observers_) 762 for (auto& observer : observers_)
759 observer.NavigationItemCommitted(load_details); 763 observer.NavigationItemCommitted(load_details);
760 } 764 }
761 765
762 WebState* WebStateImpl::GetWebState() { 766 WebState* WebStateImpl::GetWebState() {
763 return this; 767 return this;
764 } 768 }
765 769
766 } // namespace web 770 } // namespace web
OLDNEW
« no previous file with comments | « ios/web/web_state/web_state_impl.h ('k') | ios/web_view/internal/cwv_web_view.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698