Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Side by Side Diff: ios/web/public/navigation_manager.h

Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController. (Closed)
Patch Set: Rebase and Remove DCHECK in |loadWithParams| as it has already been taken care of Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_PUBLIC_NAVIGATION_MANAGER_H_ 5 #ifndef IOS_WEB_PUBLIC_NAVIGATION_MANAGER_H_
6 #define IOS_WEB_PUBLIC_NAVIGATION_MANAGER_H_ 6 #define IOS_WEB_PUBLIC_NAVIGATION_MANAGER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #import "base/mac/scoped_nsobject.h" 10 #import "base/mac/scoped_nsobject.h"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 virtual bool CanGoToOffset(int offset) const = 0; 146 virtual bool CanGoToOffset(int offset) const = 0;
147 virtual void GoBack() = 0; 147 virtual void GoBack() = 0;
148 virtual void GoForward() = 0; 148 virtual void GoForward() = 0;
149 149
150 // Navigates to the specified absolute index. 150 // Navigates to the specified absolute index.
151 // TODO(crbug.com/533848): Update to use size_t. 151 // TODO(crbug.com/533848): Update to use size_t.
152 virtual void GoToIndex(int index) = 0; 152 virtual void GoToIndex(int index) = 0;
153 153
154 // Reloads the visible item under the specified ReloadType. If 154 // Reloads the visible item under the specified ReloadType. If
155 // |check_for_repost| is true and the current item has POST data the user is 155 // |check_for_repost| is true and the current item has POST data the user is
156 // prompted to see if they really want to reload the page. In nearly all cases 156 // prompted to see if they really want to reload the page. Pass in true if the
157 // pass in true. If a transient item is showing, initiates a new navigation 157 // reload is explicitly initiated by the user. If a transient item is showing,
158 // to its URL. 158 // initiates a new navigation to its URL.
159 // TODO(crbug.com/700571): implement the logic for when |reload_type| is 159 // TODO(crbug.com/700571): implement the logic for when |reload_type| is
160 // ORIGINAL_REQUEST_URL. 160 // ORIGINAL_REQUEST_URL.
161 // TODO(crbug.com/700958): implement the logic for |check_for_repost|. 161 // TODO(crbug.com/700958): implement the logic for |check_for_repost|.
162 virtual void Reload(ReloadType reload_type, bool check_for_repost) = 0; 162 virtual void Reload(ReloadType reload_type, bool check_for_repost) = 0;
163 163
164 // Returns a list of all non-redirected NavigationItems whose index precedes 164 // Returns a list of all non-redirected NavigationItems whose index precedes
165 // or follows the current index. 165 // or follows the current index.
166 virtual NavigationItemList GetBackwardItems() const = 0; 166 virtual NavigationItemList GetBackwardItems() const = 0;
167 virtual NavigationItemList GetForwardItems() const = 0; 167 virtual NavigationItemList GetForwardItems() const = 0;
168 168
(...skipping 20 matching lines...) Expand all
189 // Forces the pending item to be loaded using desktop user agent. Note that 189 // Forces the pending item to be loaded using desktop user agent. Note that
190 // the pending item may or may not already exist. 190 // the pending item may or may not already exist.
191 // TODO(crbug.com/692303): Remove this when overriding the user agent doesn't 191 // TODO(crbug.com/692303): Remove this when overriding the user agent doesn't
192 // create a new NavigationItem. 192 // create a new NavigationItem.
193 virtual void OverrideDesktopUserAgentForNextPendingItem() = 0; 193 virtual void OverrideDesktopUserAgentForNextPendingItem() = 0;
194 }; 194 };
195 195
196 } // namespace web 196 } // namespace web
197 197
198 #endif // IOS_WEB_PUBLIC_NAVIGATION_MANAGER_H_ 198 #endif // IOS_WEB_PUBLIC_NAVIGATION_MANAGER_H_
OLDNEW
« no previous file with comments | « ios/web/navigation/navigation_manager_impl_unittest.mm ('k') | ios/web/web_state/ui/crw_web_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698