Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: ios/web_view/internal/cwv_web_view.mm

Issue 2741413007: Refactoring Reload in NavigationManager and CRWWebController. (Closed)
Patch Set: fixed more check_for_repost errors Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web_view/public/cwv_web_view.h" 5 #import "ios/web_view/public/cwv_web_view.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #import "base/ios/weak_nsobject.h" 10 #import "base/ios/weak_nsobject.h"
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 if (_webState->GetNavigationManager()) 125 if (_webState->GetNavigationManager())
126 _webState->GetNavigationManager()->GoBack(); 126 _webState->GetNavigationManager()->GoBack();
127 } 127 }
128 128
129 - (void)goForward { 129 - (void)goForward {
130 if (_webState->GetNavigationManager()) 130 if (_webState->GetNavigationManager())
131 _webState->GetNavigationManager()->GoForward(); 131 _webState->GetNavigationManager()->GoForward();
132 } 132 }
133 133
134 - (void)reload { 134 - (void)reload {
135 _webState->GetNavigationManager()->Reload(web::ReloadType::NORMAL, true); 135 // |check_for_repost| is false because CWVWebView does not support form
Eugene But (OOO till 7-30) 2017/03/16 18:39:04 s/form resubmission/repost form Sorry we have spe
liaoyuke 2017/03/17 17:59:21 Done.
136 // resubmission dialogs.
137 _webState->GetNavigationManager()->Reload(web::ReloadType::NORMAL,
138 false /* check_for_repost */);
136 } 139 }
137 140
138 - (void)stopLoading { 141 - (void)stopLoading {
139 _webState->Stop(); 142 _webState->Stop();
140 } 143 }
141 144
142 - (void)loadRequest:(NSURLRequest*)request { 145 - (void)loadRequest:(NSURLRequest*)request {
143 DCHECK_EQ(nil, request.HTTPBodyStream) 146 DCHECK_EQ(nil, request.HTTPBodyStream)
144 << "request.HTTPBodyStream is not supported."; 147 << "request.HTTPBodyStream is not supported.";
145 148
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 userGestureLocation:params.location]; 230 userGestureLocation:params.location];
228 return YES; 231 return YES;
229 } 232 }
230 233
231 - (web::JavaScriptDialogPresenter*)javaScriptDialogPresenterForWebState: 234 - (web::JavaScriptDialogPresenter*)javaScriptDialogPresenterForWebState:
232 (web::WebState*)webState { 235 (web::WebState*)webState {
233 return _javaScriptDialogPresenter.get(); 236 return _javaScriptDialogPresenter.get();
234 } 237 }
235 238
236 @end 239 @end
OLDNEW
« ios/web/web_state/ui/crw_web_controller.mm ('K') | « ios/web/web_state/web_state_impl.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698