Refactoring Reload in NavigationManager and CRWWebController.

ios/web/navigation/navigation_manager_impl_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/navigation/navigation_manager_impl.h"
 
 #include "base/logging.h"
 #import "base/mac/scoped_nsobject.h"
 #import "ios/web/navigation/crw_session_controller+private_constructors.h"
 #import "ios/web/navigation/navigation_manager_delegate.h"
@@ skipping 579 matching lines @@
   ASSERT_EQ(web::UserAgentType::NONE, native_item2->GetUserAgentType());
   navigation_manager()->AddPendingItem(
       GURL("http://www.3.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
       web::NavigationInitiationType::USER_INITIATED);
   [session_controller() commitPendingItem];
   web::NavigationItem* item3 = navigation_manager()->GetLastCommittedItem();
 
   // Verify that |item2|'s UserAgentType is propagated to |item3|.
   EXPECT_EQ(item2->GetUserAgentType(), item3->GetUserAgentType());
 }
 

[Eugene But (OOO till 7-30), 2017/03/15 17:53:32]

Can we add more tests? Specifically tests which would catch bugs in
NavigationManagerImpl::Reload

+// Tests that calling |Reload| on NavigationManager leaves the Url of the
+// visible item unchanged.
+TEST_F(NavigationManagerTest, ReloadWithNormalReloadType) {
+  navigation_manager()->AddPendingItem(
+      GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+      web::NavigationInitiationType::USER_INITIATED);
+  ASSERT_TRUE(navigation_manager()->GetVisibleItem());
+
+  GURL url_before_reload = navigation_manager()->GetVisibleItem()->GetURL();
+  navigation_manager()->Reload(web::ReloadType::NORMAL, true);

[Eugene But (OOO till 7-30), 2017/03/15 17:53:32]

nit: /*check_for_repost*/

+
+  EXPECT_EQ(url_before_reload,
+            navigation_manager()->GetVisibleItem()->GetURL());
+}
+
 }  // namespace web