ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm - Issue 2741343015: Add a BrowserState* parameter to GetEarlyPageScript().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm

Issue 2741343015: Add a BrowserState* parameter to GetEarlyPageScript(). (Closed)

Patch Set: Apply review comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm

diff --git a/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm b/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm

index 6bac135ee5ea16241a42f4abb3ddc7ccf58b39ab..2432724ce19719c7ce58b62bf395c5c9033f5808 100644

--- a/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm

+++ b/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm

@@ -137,7 +137,7 @@ TEST_F(WKWebViewConfigurationProviderTest, UserScript) {

WKWebViewConfiguration* config = GetProvider().GetWebViewConfiguration();

NSArray* scripts = config.userContentController.userScripts;

EXPECT_EQ(1U, scripts.count);

- NSString* early_script = GetEarlyPageScript();

+ NSString* early_script = GetEarlyPageScript(&browser_state_);

// |earlyScript| is a substring of |userScripts|. The latter wraps the

// former with "if (!injected)" check to avoid double injections.

EXPECT_LT(0U, [[scripts[0] source] rangeOfString:early_script].length);

« no previous file with comments | « ios/web/web_state/ui/wk_web_view_configuration_provider.mm ('k') | no next file » | no next file with comments »