ios/chrome/browser/web/chrome_web_client_unittest.mm - Issue 2741343015: Add a BrowserState* parameter to GetEarlyPageScript().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/web/chrome_web_client_unittest.mm

Issue 2741343015: Add a BrowserState* parameter to GetEarlyPageScript(). (Closed)

Patch Set: Apply review comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/web/chrome_web_client_unittest.mm

diff --git a/ios/chrome/browser/web/chrome_web_client_unittest.mm b/ios/chrome/browser/web/chrome_web_client_unittest.mm

index 80c6a15fd03f98d2f58c3457ec48906a91d630a4..fc3763e2737ecded0cafc0b70d5ea5053e6b82b0 100644

--- a/ios/chrome/browser/web/chrome_web_client_unittest.mm

+++ b/ios/chrome/browser/web/chrome_web_client_unittest.mm

@@ -76,7 +76,7 @@ TEST_F(ChromeWebClientTest, WKWebViewEarlyPageScript) {

web::ExecuteJavaScript(web_view, @"__gCrWeb = {};");

web::ScopedTestingWebClient web_client(base::MakeUnique<ChromeWebClient>());

- NSString* script = web_client.Get()->GetEarlyPageScript();

+ NSString* script = web_client.Get()->GetEarlyPageScript(&browser_state);

web::ExecuteJavaScript(web_view, script);

EXPECT_NSEQ(@"object",

web::ExecuteJavaScript(web_view, @"typeof __gCrWeb.print"));