services/ui/ws/DEPS - Issue 2741343003: Update liftetime management of GpuClient

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/ui/ws/DEPS

Issue 2741343003: Update liftetime management of GpuClient (Closed)

Patch Set: Address Review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+gpu/command_buffer/client",	2 "+gpu/command_buffer/client",

3 "+gpu/config",	3 "+gpu/config",

4 "+gpu/ipc/client",	4 "+gpu/ipc/client",

5 "+gpu/ipc/common",	5 "+gpu/ipc/common",

	6 "+gpu/ipc/service",

	7 "+services/ui/gpu",
	sadrul 2017/03/23 15:26:56 Hrm. I guess these are for the tests. Can you move Hrm. I guess these are for the tests. Can you move that to a file-specific rule? We would want to avoid accidental use of these code in the window-server. jonross 2017/03/23 16:41:39 Done. Show quoted text On 2017/03/23 15:26:56, sadrul wrote: > Hrm. I guess these are for the tests. Can you move that to a file-specific rule? > We would want to avoid accidental use of these code in the window-server. Done.
6 "+services/ui/gpu/interfaces",	8 "+services/ui/gpu/interfaces",

7 "-services/ui/surfaces",	9 "-services/ui/surfaces",

8 ]	10 ]

9	11

10 specific_include_rules = {	12 specific_include_rules = {

11 "gpu_host.h": [	13 "gpu_host.h": [

12 "+services/ui/gpu/gpu_main.h",	14 "+services/ui/gpu/gpu_main.h",

13 ],	15 ],

14 }	16 }

OLD	NEW

« no previous file with comments | « services/ui/ws/BUILD.gn ('k') | services/ui/ws/gpu_client.h » ('j') | no next file with comments »