Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 2741313002: Renamed WasWithinSamePage to WasWithinSameDocument. (Closed)
Patch Set: Even moar fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_aura_browsertest.cc
diff --git a/content/browser/web_contents/web_contents_view_aura_browsertest.cc b/content/browser/web_contents/web_contents_view_aura_browsertest.cc
index c88996dcc79d76d644aca2eab17d63e17a9f8113..870da9c8f903cff2d9bf87f7a9cb3bc1c03570f2 100644
--- a/content/browser/web_contents/web_contents_view_aura_browsertest.cc
+++ b/content/browser/web_contents/web_contents_view_aura_browsertest.cc
@@ -706,17 +706,17 @@ IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, ReplaceStateReloadPushState) {
WaitForLoadStop(web_contents);
// reloading the page shouldn't capture a screenshot
// TODO (mfomitchev): currently broken. Uncomment when
- // FrameHostMsg_DidCommitProvisionalLoad_Params.was_within_same_page
+ // FrameHostMsg_DidCommitProvisionalLoad_Params.was_within_same_document
// is populated properly when reloading the page.
- //EXPECT_FALSE(screenshot_manager()->screenshot_taken_for());
+ // EXPECT_FALSE(screenshot_manager()->screenshot_taken_for());
Charlie Reis 2017/03/15 02:43:10 I assume this still fails if we uncomment it? (Mi
Eugene But (OOO till 7-30) 2017/03/15 16:16:17 Filed crbug.com/701801 for this.
screenshot_manager()->Reset();
ExecuteSyncJSFunction(main_frame, "use_push_state()");
screenshot_manager()->WaitUntilScreenshotIsReady();
// pushing a state shouldn't capture a screenshot
// TODO (mfomitchev): currently broken. Uncomment when
- // FrameHostMsg_DidCommitProvisionalLoad_Params.was_within_same_page
+ // FrameHostMsg_DidCommitProvisionalLoad_Params.was_within_same_document
// is populated properly when pushState is used.
- //EXPECT_FALSE(screenshot_manager()->screenshot_taken_for());
+ // EXPECT_FALSE(screenshot_manager()->screenshot_taken_for());
}
// TODO(sadrul): This test is disabled because it reparents in a way the

Powered by Google App Engine
This is Rietveld 408576698