Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: content/browser/frame_host/navigator_impl_unittest.cc

Issue 2741313002: Renamed WasWithinSamePage to WasWithinSameDocument. (Closed)
Patch Set: Even moar fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl_unittest.cc
diff --git a/content/browser/frame_host/navigator_impl_unittest.cc b/content/browser/frame_host/navigator_impl_unittest.cc
index c5b35f16ce706452abdb2928caa2cb28a3a951bc..0d2f9b0f29c1790237b866dece5c8c94d5dc91f7 100644
--- a/content/browser/frame_host/navigator_impl_unittest.cc
+++ b/content/browser/frame_host/navigator_impl_unittest.cc
@@ -1140,16 +1140,17 @@ TEST_F(NavigatorTestWithBrowserSideNavigation,
}
namespace {
-void SetWithinPage(const GURL& url,
- FrameHostMsg_DidCommitProvisionalLoad_Params* params) {
- params->was_within_same_page = true;
+void SetWithinSameDocument(
+ const GURL& url,
+ FrameHostMsg_DidCommitProvisionalLoad_Params* params) {
+ params->was_within_same_document = true;
params->url = url;
params->origin = url::Origin(url);
}
}
// A renderer process might try and claim that a cross site navigation was
-// within the same page by setting was_within_same_page = true for
+// within the same document by setting was_within_same_document = true for
// FrameHostMsg_DidCommitProvisionalLoad. Such case should be detected on the
// browser side and the renderer process should be killed.
TEST_F(NavigatorTestWithBrowserSideNavigation, CrossSiteClaimWithinPage) {
@@ -1166,7 +1167,7 @@ TEST_F(NavigatorTestWithBrowserSideNavigation, CrossSiteClaimWithinPage) {
// Claim that the navigation was within same page.
int bad_msg_count = process()->bad_msg_count();
GetSpeculativeRenderFrameHost(node)->SendNavigateWithModificationCallback(
- entry_id, true, kUrl2, base::Bind(SetWithinPage, kUrl1));
+ entry_id, true, kUrl2, base::Bind(SetWithinSameDocument, kUrl1));
EXPECT_EQ(process()->bad_msg_count(), bad_msg_count + 1);
}

Powered by Google App Engine
This is Rietveld 408576698