Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10364)

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_delegate.cc

Issue 2741313002: Renamed WasWithinSamePage to WasWithinSameDocument. (Closed)
Patch Set: Even moar fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
diff --git a/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc b/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
index 92043a0d96408cb4d2859f02686e3ccaf3d4b5ca..03575c3d4d7341a22dd2113aac181ca6adeebcc0 100644
--- a/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
+++ b/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
@@ -143,8 +143,8 @@ void PhishingClassifierDelegate::OnStartPhishingDetection(const GURL& url) {
}
void PhishingClassifierDelegate::DidCommitProvisionalLoad(
- bool is_new_navigation,
- bool is_same_page_navigation) {
+ bool /*is_new_navigation*/,
+ bool /*is_same_page_navigation*/) {
Charlie Reis 2017/03/15 02:43:10 Let's leave this change out. It's unrelated, and
Eugene But (OOO till 7-30) 2017/03/15 16:16:16 Done.
blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
// A new page is starting to load, so cancel classificaiton.
//
@@ -156,7 +156,7 @@ void PhishingClassifierDelegate::DidCommitProvisionalLoad(
DocumentState* document_state = DocumentState::FromDataSource(
frame->dataSource());
NavigationState* navigation_state = document_state->navigation_state();
- CancelPendingClassification(navigation_state->WasWithinSamePage()
+ CancelPendingClassification(navigation_state->WasWithinSameDocument()
? NAVIGATE_WITHIN_PAGE
: NAVIGATE_AWAY);
if (frame->parent())

Powered by Google App Engine
This is Rietveld 408576698