Enabling alwaysOnTop should fail to create app windows if the permission is lacking

Enabling alwaysOnTop should fail to create app windows if the permission is lacking

If the alwaysOnTop property is enabled, but the app.window.alwaysOnTop
permission is not specified in the manifest, app window creation will
now fail with an error.

BUG=371213
TEST=browser_tests 
(PlatformAppBrowserTest.WindowsApiAlwaysOnTopNoPermissions)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270045

[tmdiep, 2014-05-13 04:01:21]

benwells: This is the patch for failing early when alwaysOnTop permission is
lacking. Thanks in advance.

[benwells, 2014-05-13 04:16:00]

just nits, lgtm.

https://codereview.chromium.org/274123003/diff/1/chrome/test/data/extensions/...
File
chrome/test/data/extensions/platform_apps/windows_api_always_on_top/no_permissions/background.js
(right):

https://codereview.chromium.org/274123003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/windows_api_always_on_top/no_permissions/background.js:19:
chrome.test.waitForRoundTrip("msg", callbackPass(function(msg) {
Nit: you can drop the msg parameter to this function as you don't use it. You
can also replace "msg" with "".

https://codereview.chromium.org/274123003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/windows_api_always_on_top/no_permissions/background.js:21:
chrome.test.assertEq(false, win.isAlwaysOnTop());
Nit: you can use chrome.test.assertFalse

[tmdiep, 2014-05-13 05:16:09]

The CQ bit was checked by tmdiep@chromium.org

[commit-bot: I haz the power, 2014-05-13 05:16:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tmdiep@chromium.org/274123003/20001

[commit-bot: I haz the power, 2014-05-13 07:29:11]

Change committed as 270045