Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2741223002: Use correct ScrollbarTheme to paintScrollCorner (Closed)
Patch Set: remove NOTREACHED handler Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index e4c8df9640211892d556ce0e1292500a8fcacc1a..50ce511325f829f70f1b7060da0f9cb54dba6011 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -11190,6 +11190,21 @@ TEST_F(WebFrameTest, MouseReleaseUpdatesScrollbarHoveredPart) {
EXPECT_EQ(scrollbar->hoveredPart(), ScrollbarPart::NoPart);
}
+TEST_F(WebFrameTest,
+ CustomScrollbarInOverlayScrollbarThemeWillNotCauseDCHECKFails) {
+ registerMockedHttpURLLoad(
+ "custom-scrollbar-dcheck-failed-when-paint-scroll-corner.html");
+ FrameTestHelpers::WebViewHelper webViewHelper;
+ WebViewImpl* webView = webViewHelper.initializeAndLoad(
+ m_baseURL +
+ "custom-scrollbar-dcheck-failed-when-paint-scroll-corner.html");
+
+ webViewHelper.resize(WebSize(200, 200));
+
+ // No DCHECK Fails. Issue 676678.
+ webView->updateAllLifecyclePhases();
+}
+
static void disableCompositing(WebSettings* settings) {
settings->setAcceleratedCompositingEnabled(false);
settings->setPreferCompositingToLCDTextEnabled(false);

Powered by Google App Engine
This is Rietveld 408576698