Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2741173002: Reduce canonicalization when dragging (Closed)
Patch Set: update Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index b53e47fc7df02c2823e0edb3b917245e9d536d6d..c253d60a8b364671d45f1bfe5f988ce3df32485e 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -387,6 +387,9 @@ void SelectionController::updateSelectionForMouseDrag(
} else {
basePosition = selection().computeVisibleSelectionInFlatTree().base();
}
+ if (basePosition.isNull())
+ return;
+
const SelectionInFlatTree& appliedSelection = applySelectAll(
basePosition, targetPosition.deepEquivalent(), mousePressNode,
dragStartPos, target, hitTestResult.localPoint());

Powered by Google App Engine
This is Rietveld 408576698