Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.cpp

Issue 2741173002: Reduce canonicalization when dragging (Closed)
Patch Set: update Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameCaret.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.cpp b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
index cba2d8cf917e029900e989b4d2b4023fddf15393..fcfa1acf9324bec2e61a73f64e66cbf0bab8656b 100644
--- a/third_party/WebKit/Source/core/editing/FrameCaret.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
@@ -204,7 +204,8 @@ bool FrameCaret::shouldBlinkCaret() const {
if (m_caretVisibility != CaretVisibility::Visible || !isActive())
return false;
- Element* root = rootEditableElementOf(caretPosition().position());
+ Element* root =
+ rootEditableElementOf(m_selectionEditor->selectionInDOMTree().base());
yosin_UTC9 2017/03/16 02:30:05 Could you move change in another CL? This change i
yoichio 2017/03/16 04:10:59 Acknowledged.
if (!root)
return false;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698