Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2740953003: Add TODO to deprecate ComputedStyle::operator==. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
6 * rights reserved. 6 * rights reserved.
7 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 2320 matching lines...) Expand 10 before | Expand all | Expand 10 after
2331 float strokeOpacity() const { return svgStyle().strokeOpacity(); } 2331 float strokeOpacity() const { return svgStyle().strokeOpacity(); }
2332 void setStrokeOpacity(float f) { accessSVGStyle().setStrokeOpacity(f); } 2332 void setStrokeOpacity(float f) { accessSVGStyle().setStrokeOpacity(f); }
2333 2333
2334 // stroke-width 2334 // stroke-width
2335 const UnzoomedLength& strokeWidth() const { return svgStyle().strokeWidth(); } 2335 const UnzoomedLength& strokeWidth() const { return svgStyle().strokeWidth(); }
2336 void setStrokeWidth(const UnzoomedLength& w) { 2336 void setStrokeWidth(const UnzoomedLength& w) {
2337 accessSVGStyle().setStrokeWidth(w); 2337 accessSVGStyle().setStrokeWidth(w);
2338 } 2338 }
2339 2339
2340 // Comparison operators 2340 // Comparison operators
2341 // TODO(shend): Replace callers of operator== wth a named method instead, e.g.
sashab 2017/03/09 23:38:37 Nit - end with full stop ;)
2342 // inheritedEquals()
2341 bool operator==(const ComputedStyle& other) const; 2343 bool operator==(const ComputedStyle& other) const;
2342 bool operator!=(const ComputedStyle& other) const { 2344 bool operator!=(const ComputedStyle& other) const {
2343 return !(*this == other); 2345 return !(*this == other);
2344 } 2346 }
2345 2347
2346 bool inheritedEqual(const ComputedStyle&) const; 2348 bool inheritedEqual(const ComputedStyle&) const;
2347 bool nonInheritedEqual(const ComputedStyle&) const; 2349 bool nonInheritedEqual(const ComputedStyle&) const;
2348 inline bool independentInheritedEqual(const ComputedStyle&) const; 2350 inline bool independentInheritedEqual(const ComputedStyle&) const;
2349 inline bool nonIndependentInheritedEqual(const ComputedStyle&) const; 2351 inline bool nonIndependentInheritedEqual(const ComputedStyle&) const;
2350 bool loadingCustomFontsEqual(const ComputedStyle&) const; 2352 bool loadingCustomFontsEqual(const ComputedStyle&) const;
(...skipping 1449 matching lines...) Expand 10 before | Expand all | Expand 10 after
3800 m_nonInheritedData.m_pseudoBits |= 1 << (pseudo - FirstPublicPseudoId); 3802 m_nonInheritedData.m_pseudoBits |= 1 << (pseudo - FirstPublicPseudoId);
3801 } 3803 }
3802 3804
3803 inline bool ComputedStyle::hasPseudoElementStyle() const { 3805 inline bool ComputedStyle::hasPseudoElementStyle() const {
3804 return m_nonInheritedData.m_pseudoBits & ElementPseudoIdMask; 3806 return m_nonInheritedData.m_pseudoBits & ElementPseudoIdMask;
3805 } 3807 }
3806 3808
3807 } // namespace blink 3809 } // namespace blink
3808 3810
3809 #endif // ComputedStyle_h 3811 #endif // ComputedStyle_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698