Add TODO to deprecate ComputedStyle::operator==.

third_party/WebKit/Source/core/style/ComputedStyle.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 2320 matching lines @@
   float strokeOpacity() const { return svgStyle().strokeOpacity(); }
   void setStrokeOpacity(float f) { accessSVGStyle().setStrokeOpacity(f); }
 
   // stroke-width
   const UnzoomedLength& strokeWidth() const { return svgStyle().strokeWidth(); }
   void setStrokeWidth(const UnzoomedLength& w) {
     accessSVGStyle().setStrokeWidth(w);
   }
 
   // Comparison operators
+  // TODO(shend): deprecate operator== in favour of a named method

[sashab, 2017/03/09 22:57:45]

nit, start with capital letter and end with full stop (see style guide). Also
word it in a more actionable way, eg:

"Replace users of operator== with a named method instead, e.g.
inheritedEqual()."

[shend, 2017/03/09 23:07:57]

Got it. Done.

   bool operator==(const ComputedStyle& other) const;
   bool operator!=(const ComputedStyle& other) const {
     return !(*this == other);
   }
 
   bool inheritedEqual(const ComputedStyle&) const;
   bool nonInheritedEqual(const ComputedStyle&) const;
   inline bool independentInheritedEqual(const ComputedStyle&) const;

[sashab, 2017/03/09 22:57:45]

Unrelated to this patch... Check with dcheng/esprehn but I think the naming
convention we are aiming for is "isEqual", "isEmpty", "isInheritedEqual" etc for
boolean comparison methods. So we might wanna rename these at some point, maybe
add a todo as well (you can just do it in this patch, or make a new patch and
get them to review it).

   inline bool nonIndependentInheritedEqual(const ComputedStyle&) const;
   bool loadingCustomFontsEqual(const ComputedStyle&) const;
   bool inheritedDataShared(const ComputedStyle&) const;
 
   bool hasChildDependentFlags() const {
     return emptyState() || hasExplicitlyInheritedProperties();
   }
   void copyChildDependentFlagsFrom(const ComputedStyle&);
 
   // Counters.
@@ skipping 1441 matching lines @@
   m_nonInheritedData.m_pseudoBits |= 1 << (pseudo - FirstPublicPseudoId);
 }
 
 inline bool ComputedStyle::hasPseudoElementStyle() const {
   return m_nonInheritedData.m_pseudoBits & ElementPseudoIdMask;
 }
 
 }  // namespace blink
 
 #endif  // ComputedStyle_h