Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 274093002: Fixed d8 shutdown. (Closed)

Created:
6 years, 7 months ago by Sven Panne
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fixed d8 shutdown. It is crucial that the Isolate is cleanly disposed, otherwise the optimizing compiler thread happily continues to run. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/d8.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 7 months ago (2014-05-09 11:28:27 UTC) #1
Yang
On 2014/05/09 11:28:27, Sven Panne wrote: lgtm
6 years, 7 months ago (2014-05-09 11:28:38 UTC) #2
Sven Panne
6 years, 7 months ago (2014-05-09 11:29:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21214 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698