MD Bookmarks: Implement search and selection in new data flow system

chrome/browser/resources/md_bookmarks/reducers.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Module of functions which produce a new page state in response
  * to an action. Reducers (in the same sense as Array.prototype.reduce) must be
  * pure functions: they must not modify existing state objects, or make any API
  * calls.
  */
 
 cr.define('bookmarks', function() {
+  var SearchState = {};
+
+  /**
+   * @param {SearchState} search
+   * @param {Action} action
+   * @return {SearchState}
+   */
+  SearchState.startSearch = function(search, action) {
+    return {
+      term: action.term,
+      inProgress: true,
+      results: [],
+    };
+  };
+
+  /**
+   * @param {SearchState} search
+   * @param {Action} action
+   * @return {SearchState}
+   */
+  SearchState.finishSearch = function(search, action) {
+    return /** @type {SearchState} */ (Object.assign({}, search, {
+      inProgress: false,
+      results: action.results,
+    }));
+  };
+
+  /** @return {SearchState} */
+  SearchState.clearSearch = function() {
+    return {
+      term: '',
+      inProgress: false,
+      results: [],
+    };
+  };
+
+  /**
+   * @param {SearchState} search
+   * @param {Action} action
+   * @return {SearchState}
+   */
+  SearchState.updateSearch = function(search, action) {
+    switch (action.name) {
+      case 'start-search':
+        return SearchState.startSearch(search, action);
+      case 'select-folder':
+      case 'clear-search':
+        return SearchState.clearSearch();
+      case 'finish-search':
+        return SearchState.finishSearch(search, action);
+      default:
+        return search;
+    }
+  };
+
   var NodeState = {};
 
   /**
    * @param {NodeList} nodes
    * @param {string} id
    * @param {function(BookmarkNode):BookmarkNode} callback
    * @return {NodeList}
    */
   NodeState.modifyNode_ = function(nodes, id, callback) {
     var nodeModification = {};
@@ skipping 20 matching lines @@
   /**
    * @param {NodeList} nodes
    * @param {Action} action
    * @return {NodeList}
    */
   NodeState.removeBookmark = function(nodes, action) {
     return NodeState.modifyNode_(nodes, action.parentId, function(node) {
       var newChildren = node.children.slice();
       newChildren.splice(action.index, 1);
       return /** @type {BookmarkNode} */ (
           Object.assign({}, node, {children: newChildren}));

[calamity, 2017/03/13 04:50:36]

Was this supposed to have a TODO to remove the node from the nodemap?

[tsergeant, 2017/03/14 02:40:36]

That TODO lives in the test file (and as above, I'm working on the CL for it
now).

     });
   };
 
   /**
    * @param {NodeList} nodes
    * @param {Action} action
    * @return {NodeList}
    */
   NodeState.updateNodes = function(nodes, action) {
     switch (action.name) {
@@ skipping 41 matching lines @@
         return action.id;
       case 'change-folder-open':
         // When hiding the selected folder by closing its ancestor, select
         // that ancestor instead.
         if (!action.open && selectedFolder &&
             SelectedFolderState.isAncestorOf(
                 nodes, action.id, selectedFolder)) {
           return action.id;
         }
         return selectedFolder;
+      case 'finish-search':
+        return null;
+      case 'clear-search':
+        return nodes['0'].children[0];

[calamity, 2017/03/13 04:50:36]

Add a TODO to make this return to the previously selected folder?

[tsergeant, 2017/03/14 02:40:36]

Done.

       default:
         return selectedFolder;
     }
   };
 
   var ClosedFolderState = {};
 
   /**
    * @param {ClosedFolderState} state
    * @param {Action} action
@@ skipping 51 matching lines @@
    * @param {Action} action
    * @return {!BookmarksPageState}
    */
   function reduceAction(state, action) {
     return {
       nodes: NodeState.updateNodes(state.nodes, action),
       selectedFolder: SelectedFolderState.updateSelectedFolder(
           state.selectedFolder, action, state.nodes),
       closedFolders: ClosedFolderState.updateClosedFolders(
           state.closedFolders, action, state.nodes),
+      search: SearchState.updateSearch(state.search, action),
     };
   }
 
   return {
     reduceAction: reduceAction,
     ClosedFolderState: ClosedFolderState,
     NodeState: NodeState,
+    SearchState: SearchState,
     SelectedFolderState: SelectedFolderState,
   };
 });