content/renderer/gpu/queue_message_swap_promise.cc - Issue 2740833005: [cc] Pass on BeginFrameAcks from CompositorEBFS through RWHVAura, DFH.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/queue_message_swap_promise.cc

Issue 2740833005: [cc] Pass on BeginFrameAcks from CompositorEBFS through RWHVAura, DFH. (Closed)

Patch Set: address security comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/gpu/queue_message_swap_promise.cc

diff --git a/content/renderer/gpu/queue_message_swap_promise.cc b/content/renderer/gpu/queue_message_swap_promise.cc

index f8a53314f9e75c0548f3236d0787df0d2f5d262b..adcf340bbef20406712437e58ab99b227be37a87 100644

--- a/content/renderer/gpu/queue_message_swap_promise.cc

+++ b/content/renderer/gpu/queue_message_swap_promise.cc

@@ -59,6 +59,8 @@ cc::SwapPromise::DidNotSwapAction QueueMessageSwapPromise::DidNotSwap(

#if DCHECK_IS_ON()

DCHECK(!completed_);

#endif

+ // TODO(eseckler): Deliver messages with next ViewHostMsg_BeginFrameDidNotSwap

+ // or ViewHostMsg_SwapCompositorFrame instead of sending them here directly.

std::vector<std::unique_ptr<IPC::Message>> messages;

message_queue_->DidNotSwap(source_frame_number_, reason, &messages);

for (auto& msg : messages) {