content/renderer/gpu/compositor_external_begin_frame_source.h - Issue 2740833005: [cc] Pass on BeginFrameAcks from CompositorEBFS through RWHVAura, DFH.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/compositor_external_begin_frame_source.h

Issue 2740833005: [cc] Pass on BeginFrameAcks from CompositorEBFS through RWHVAura, DFH. (Closed)

Patch Set: address security comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/gpu/compositor_external_begin_frame_source.h

diff --git a/content/renderer/gpu/compositor_external_begin_frame_source.h b/content/renderer/gpu/compositor_external_begin_frame_source.h

index e7089fba80cb77c2b04994f50a5ede1b0cdfc5b7..d8826e06fc614d7e4c1f8d697939045ff1d2382a 100644

--- a/content/renderer/gpu/compositor_external_begin_frame_source.h

+++ b/content/renderer/gpu/compositor_external_begin_frame_source.h

@@ -43,9 +43,8 @@ class CompositorExternalBeginFrameSource

// cc::BeginFrameSource implementation.

void AddObserver(cc::BeginFrameObserver* obs) override;

void RemoveObserver(cc::BeginFrameObserver* obs) override;

- // TODO(eseckler): Track and forward BeginFrameAcks to browser.

void DidFinishFrame(cc::BeginFrameObserver* obs,

- const cc::BeginFrameAck& ack) override {}

+ const cc::BeginFrameAck& ack) override;

bool IsThrottled() const override;

// cc::ExternalBeginFrameSourceClient implementation.