Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2269)

Unified Diff: cc/scheduler/begin_frame_source.h

Issue 2740833005: [cc] Pass on BeginFrameAcks from CompositorEBFS through RWHVAura, DFH. (Closed)
Patch Set: address security comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/begin_frame_source.h
diff --git a/cc/scheduler/begin_frame_source.h b/cc/scheduler/begin_frame_source.h
index 3b4e5231d183c90e3d666316123220dcfa956cdb..1e1938ba40f3967d652d3b3625950d6fb11d4a73 100644
--- a/cc/scheduler/begin_frame_source.h
+++ b/cc/scheduler/begin_frame_source.h
@@ -119,6 +119,12 @@ class CC_EXPORT BeginFrameSource {
// (rather than toggling SetNeedsBeginFrames every frame). For example, the
// BackToBackFrameSource uses them to make sure only one frame is pending at a
// time.
+ //
+ // Note that the BeginFrameSource should not assume that the |ack| references
+ // a valid BeginFrame sent by the source. The |ack| may reference a BeginFrame
+ // sent by a different BeginFrameSource, and a malicious client may reference
+ // any invalid frame. The source is responsible for checking for
+ // validity/relevance of the BeginFrame itself.
// TODO(eseckler): Use BeginFrameAcks in DisplayScheduler as described above.
virtual void DidFinishFrame(BeginFrameObserver* obs,
const BeginFrameAck& ack) = 0;

Powered by Google App Engine
This is Rietveld 408576698