Issue 274083: Gtk/extensions: Convert a crash into a NOTREACHED().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274083: Gtk/extensions: Convert a crash into a NOTREACHED(). (Closed)

Created:
11 years, 2 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use the proper extension id when creating browser action buttons. BUG=25066 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29361

Patch Set 4 : compile fix, 2 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/gtk/browser_actions_toolbar_gtk.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

http://codereview.chromium.org/274083/diff/1/2 File chrome/browser/gtk/browser_actions_toolbar_gtk.cc (right): http://codereview.chromium.org/274083/diff/1/2#newcode200 Line 200: browser_actions[i]->id()); I realize why this crashes. s/->id/->extension_id/

11 years, 2 months ago (2009-10-17 00:15:42 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 274083: Gtk/extensions: Convert a crash into a NOTREACHED(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : compile fix #

Patch Set 4 : compile fix, 2 #

Messages