Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2740823005: Track lastTextNode during rebuildLayoutTree. (Closed)
Patch Set: Missing reset of lastTextNode for elements. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index ba4c87caee78c6ae2f5b959121632fa4274f6141..f206f44da888bbe6d34f0089f2c71458b768c9f4 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -41,7 +41,6 @@
#include "core/dom/DocumentTiming.h"
#include "core/dom/ExecutionContext.h"
#include "core/dom/MutationObserver.h"
-#include "core/dom/StyleReattachData.h"
#include "core/dom/SynchronousMutationNotifier.h"
#include "core/dom/SynchronousMutationObserver.h"
#include "core/dom/Text.h"
@@ -343,8 +342,8 @@ class CORE_EXPORT Document : public ContainerNode,
// just for the web IDL implementation.
Element* scrollingElementNoLayout();
- void addStyleReattachData(const Node&, StyleReattachData&);
- StyleReattachData getStyleReattachData(const Node&) const;
+ void addNonAttachedStyle(const Node&, RefPtr<ComputedStyle>);
+ ComputedStyle* getNonAttachedStyle(const Node&) const;
String readyState() const;
@@ -1442,10 +1441,9 @@ class CORE_EXPORT Document : public ContainerNode,
Member<DocumentParser> m_parser;
Member<ContextFeatures> m_contextFeatures;
- // This HashMap is used to stash information (ComputedStyle, nextTextSibling)
- // generated in the Style Resolution phase that is required in the
- // Layout Tree construction phase.
- HeapHashMap<Member<const Node>, StyleReattachData> m_styleReattachDataMap;
+ // This HashMap is used to temporaily store the ComputedStyle generated in the
+ // Style Resolution phase which is used in the Layout Tree construction phase.
+ HeapHashMap<Member<const Node>, RefPtr<ComputedStyle>> m_nonAttachedStyle;
bool m_wellFormed;
« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698