third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2740823003: [PasswordGeneration] Makes generated passwords copyable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2740823003: [PasswordGeneration] Makes generated passwords copyable (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index e4e310ba992fcf14ebfbcff1c3287c593e68e7e1..ed213cad7d37b0806d87b7ec8f6c48243dd7fb79 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -325,7 +325,7 @@ bool Editor::canCopy() const {

return true;

FrameSelection& selection = frame().selection();

return selection.computeVisibleSelectionInDOMTreeDeprecated().isRange() &&

- !isInPasswordField(

+ !isInPasswordFieldWithUnrevealedPassword(

yosin_UTC9 2017/03/10 03:48:52 Could you add test in "EditorTest.cpp" for Editor:

kolos1 2017/03/10 12:50:55 Done.

frame().selection().computeVisibleSelectionInDOMTree().start());

}