Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Issue 2740803002: [DevTools] Simplify Popover API (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
index 5c8f581c6d26e4053c444b8e692a61322ad50a8e..0acb3b1fd135dcc4c84ddce74970f69f5fd66fae 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
@@ -35,6 +35,7 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
this._popoverHelper = new UI.PopoverHelper(this.element);
this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
+ this._popoverHelper.setHasPadding(true);
this._popoverHelper.setTimeout(300, 300);
/** @type {!Array<!Network.NetworkNode>} */
@@ -168,16 +169,18 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
/**
* @param {!Element|!AnchorBox} anchor
- * @param {!UI.Popover} popover
+ * @param {!UI.GlassPane} popover
+ * @return {!Promise<boolean>}
*/
_showPopover(anchor, popover) {
if (!this._hoveredNode)
- return;
+ return Promise.resolve(false);
var request = this._hoveredNode.request();
if (!request)
- return;
+ return Promise.resolve(false);
var content = Network.RequestTimingView.createTimingTable(request, this._calculator);
- popover.showForAnchor(content, anchor);
+ popover.contentElement.appendChild(content);
+ return Promise.resolve(true);
}
/**

Powered by Google App Engine
This is Rietveld 408576698