Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2740803002: [DevTools] Simplify Popover API (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 2e2f3e4ac802bac4e7e31c50d1094a406fa1218b..766294e9898c37f9e4238e02487eb9e8e7fde4cd 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -91,6 +91,7 @@ Network.NetworkLogViewColumns = class {
this._popoverHelper = new UI.PopoverHelper(this._networkLogView.element);
this._popoverHelper.initializeCallbacks(
this._getPopoverAnchor.bind(this), this._showPopover.bind(this), this._onHidePopover.bind(this));
+ this._popoverHelper.setHasPadding(true);
/** @type {!DataGrid.SortableDataGrid<!Network.NetworkNode>} */
this._dataGrid =
@@ -538,14 +539,16 @@ Network.NetworkLogViewColumns = class {
/**
* @param {!Element} anchor
- * @param {!UI.Popover} popover
+ * @param {!UI.GlassPane} popover
+ * @return {!Promise<boolean>}
*/
_showPopover(anchor, popover) {
var request = /** @type {!SDK.NetworkRequest} */ (anchor.request);
var initiator = /** @type {!Protocol.Network.Initiator} */ (request.initiator());
var content = Components.DOMPresentationUtils.buildStackTracePreviewContents(
request.target(), this._popupLinkifier, initiator.stack);
- popover.showForAnchor(content, anchor);
+ popover.contentElement.appendChild(content);
+ return Promise.resolve(true);
}
_onHidePopover() {

Powered by Google App Engine
This is Rietveld 408576698