third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html - Issue 2740803002: [DevTools] Simplify Popover API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html

Issue 2740803002: [DevTools] Simplify Popover API (Closed)

Patch Set: better Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js » ('j') | third_party/WebKit/Source/devtools/front_end/inline_editor/SwatchPopoverHelper.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html b/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html

index bed51f26525ff422b4e57e9cd482ddf8e35ec7f5..6b94eec7c309cc277f92e538d5eeba6ead65e28b 100644

--- a/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html

+++ b/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-swatch.html

@@ -59,7 +59,7 @@ function test() {

function popoverVisible()

{

- return UI.Popover._popover ? UI.Popover._popover.contentElement.isSelfOrDescendant(document.body) : false;

+ return !!document.body.querySelector('* /deep/ .spectrum-color');

lushnikov 2017/03/10 22:07:14 fyi: /deep/ is deprecated

dgozman 2017/03/11 00:00:44 Yeah :-)

}

</script>